Product preview card component solution
Design comparison
Solution retrospective
I had a small problem when using Vite. I @imported the token.scss file on the Main component but I couldn't use the constants defined in the scss file in the descendant components. I didn't research about it, but I think it's weird.
Community feedback
- @VCaramesPosted about 2 years ago
Hey @vianhg, some suggestions to improve you code:
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
There is only one heading in this challenge and that is the name of the perfume, “Gabrielle Essence Eau De Parfum”.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
Incorrect
font-family
for the sales price; it is the same on for the heading.
Happy Coding! 👻🎃
Marked as helpful0@vianhgPosted about 2 years ago@vcarames Great feedback, thanks.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord