Design comparison
Solution retrospective
Hello there š,
this one is pretty simple I guess, tried to keep my code clean and follow best practices so when I get bigger n more complex projects it would be easier for me, anyway feedback is always welcome if anyone would take a look at the code n give me any pointers,
P.S: I don't know why the generated screenshots don't look the same as the actual site preview if anyone knows why I'd appreciate it if u tell me!
take care š.
Community feedback
- @correlucasPosted over 2 years ago
Hello Badis, congratulations for your solution!
I'm with your solution open and I've to say you that you've done pretty much everything the challenge requires, well done! The card is flexible, aligned, the image and the text are responsive. You did a good work.
If I say you some tips, there's only two things you can improve:
1.Consider use flexbox to align the card, I notice that you've used a margin to do that and works, but using flex you'll have more control over the elements.
2.Use relative units as rem or em over px for a better performance in multiple screen devices.
Thats it, well done Badis, you've an accurate challenge finished.
Marked as helpful0@Shinzo99Posted over 2 years ago@correlucas Thanks for the feedback, I'll be sure to use your advice for the next challenge.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord