Skip to content
Submitted almost 2 years ago

Responsive landing page using CSS Grid and Flexbox

Michel Moreira•300
@michel-moreira
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please, consider help me to improve my code

  • Do you think that i can reduce this code? How?
  • When you compare this solution with the design, do you think that fits well?
  • Do you think that the code it is ok or can i use a different code that it is more effective and performatic?

Community feedback

  • Navendu•270
    @AshxaryaPosted almost 2 years ago

    Hi! 😊

    I have some feedback to help you out.

    Make sure you look at the accessibility report you're provided with below your solution.

    HTML 📄:

    Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

    Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

    CSS 🎨: I think for smaller projects like this it's much better to only have one stylesheet rather than multiple to have better ease of access and less clutter.

    Have a great day/night ^^

    Marked as helpful
    0
    Michel Moreira•300
    @michel-moreiraPosted almost 2 years ago

    @Ashxarya Helo

    Your feedback is very useful and welcome!

    Thanks a lot for the suggestions, I'll put them on for sure.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord