Product preview card component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @sefianeouberka!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, don't skip heading levels - start with <h1>, then use <h2>, and so on.. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0
• 

  Hugo Sanchez•270

  @HunigoleSanPosted 10 months ago

  Hello @aykinsancakli! 👋

  I want to commend you for your outstanding work, which closely aligns with the challenge requirements. Allow me to offer a suggestion that could enhance your CSS approach. 🛠️ Upon reviewing your code snippet:

  .btn:hover { 
      background: var(--color)
  }
  

  It's evident that you effectively utilize the hover pseudo-class, particularly suited for PC devices. However, it's crucial to acknowledge potential issues on mobile devices where hover behaves differently, often leading to unexpected outcomes. 📱 To address this, I recommend deactivating hover for mobile devices and utilizing the active pseudo-class instead. 🔍

  @media (max-width: 414px) { 
      .btn:hover { 
          background: none; /* Define the desired background for the button in its normal state */ 
      }
      /* Mobile styles */
      .btn:active { 
          background: var(--color)
      } 
  }
  
  

  You have the flexibility to employ this approach or explore alternative methods that better suit your preferences. The key takeaway is to gain insights into the nuances we must consider to refine our coding practices. 🛠️📘

  Marked as helpful

  0

  ---

  

  Sefiane Ouberka•100

  @sefianeouberkaPosted 10 months ago

  @HunigoleSan thank you broo

  1