Product preview card component

Community feedback

• 

  Alex•120

  @CaplexWPosted about 2 months ago

  Hello Anamay! Well, at first - it's a good job. Every thing is in it's place and according to design. It work exactly as intended, so there's not much to say except "it's a good job!". But I'll try to highlight some concepts, you might find usefull in the future.

  1. Semantic HTML markup. When we use divs it gives us all the block-element behavior, and an ablity to make it look like we want. But when we use semantic tags for headers (like h1, h2, etc...), special programs like screen-reader can now understand that it's a header of the section.
  2. Alt text for <img/> tag. Continue the acessability topic, alt text is also explaining to screen readers what is displayed on the image to people who can't see it for themselves or search engines. For this reasone it's kinda usless to add "An image of..." or "[some object] picture" to it. You can read more about how to make better alt text in this article.
  3. HTML is a content, and CSS is the look of the content. We can use CSS to control what is displayed on the screen. We can hide content and show it when certain conditions are met. But it's considered the best practice to decide what content should be displayed on the html side when it's possible. For example we can use tags <picture> and <source> with a regular <img/> to set what image we will display, based on screen size or other properties. This article from Web.dev explains in detalis how we can make media, adaptive and what's the reasoning behind such aproach.
  4. rem size is browser dependent. Using rem instead of px considered a best practice, because it helps to build responsive layouts. But we also should remember, that it means that rem is not always a default 16px. It can be changed by user who's trying to adjust font-size for his needs, or even some browser extantions. So if I'm making a breakpoint in 37.5 rem assuming it's around 600px - it actually might work in a different places for different users. That's something to keep in mind.

  Keep up the good work, keep getting better. Cheers!

  Marked as helpful

  0

  ---

  

  P

  Anamay•120

  @anamaydevPosted about 2 months ago

  Hey @CaplexW, thank you for the feedback! I’ll make sure to learn and incorporate these concepts into my next project. I really appreciate your input!

  0
• 

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Hello again, Incredible work on this! You’re making great strides, and I have a couple of suggestions that might push it even further…

  • Overusing <div> tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like <header>, <section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.

            <div class="product-type">
              <p>Perfume</p>
            </div>
            <div class="product-title">
              <p>Gabrielle Essence Eau De Parfum</p>
            </div>
  

  • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

  • This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation), <meta> description tag missing that helps search engine determine what the page is about, Something like this <meta name="description" content="description goes here" />

  • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

  I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

  Marked as helpful

  0

  ---

  

  P

  Anamay•120

  @anamaydevPosted about 2 months ago

  Hey @Stroudy, thanks so much for your feedback! I’ll definitely incorporate the following concepts into my upcoming projects:

  1. I’ll use @font-face instead of relying on third-party sources.
  2. I’ll make sure to include important <meta> tags.
  3. Instead of relying solely on rem or px, I’ll use unitless line heights to ensure proportional scaling with the font size.

  I really appreciate your insights!

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Hey @anamaydev, No problem, I'm glad you found this information useful. You got this bro! 💪

  0

  

  P

  Anamay•120

  @anamaydevPosted about 2 months ago

  Hey @Stroudy, as you suggested, I implemented changes based on your feedback for my new project, and I would love to hear your thoughts! Here is link to my new project - Four Card Feature Section

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Hey @anamaydev, I just dropped some more feedback on your latest challenge, I hope you find it useful or atleast informative, Good to see you bro! 💪

  0