Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div id="card">with the main tag to fix the accessibility issue. click here for more on web-accessibility and semantic html
To center #card on the page using flexbox, replace the height in the body with min-height:100vh.
In the media query replace the width of #card with max-width for a responsive content and there is no need for the height value. Increase the screen size to 600px.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@wiktor-nowakPosted almost 2 years ago@Hassiai Thank you for this great feedback of yours! That truely helped me to understand CSS and HTML better! ;) HAPPY CODING to you!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord