Skip to content
Submitted 3 months ago

Product-Preview-Card-Component-Responsive

M. Abubakr•250
@m-abubakr1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I have a better understanding of the Picture tag in HTML, and I will move on to cover screen reader optimization in this project. The prices are not so visible to screen readers who cannot see the visual, gonna find a better way to solve that.

What challenges did you encounter, and how did you overcome them?

The min-height should not be showing the scrollbar on 100vh, but it was giving the scrollbar. It worked on 95vh, still trying to figure out why?

What specific areas of your project would you like help with?

Better Improvisations and developing standards for screen readers as well. Plus The min-height:100vh; giving a scrollbar is confusing.

Community feedback

  • KapteynUniverse•2,880
    @KapteynUniversePosted 3 months ago

    Hey Abubakr, nice job.

    margin: 1rem; + min-height:100vh giving the scrollbar. You don't need margin on the body.

    Edit: I guess you added margin so article won't touch edges on small screens, you can use margin-inline instead

    Marked as helpful
    1
    M. Abubakr•250
    @m-abubakr1Posted 3 months ago

    @KapteynUniverse The Feedback I needed 🤝🏻, Thanks for pointing it out.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord