Product preview card component (Responsive)

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey,

  Great work there! your submission looks very close to the solution screenshot. I've noticed few issues, so i'd like to make suggestions based on that:

  • Try to avoid giving fixed height for elements/containers that contain text elements. It will cause accessibility issue, when user changes their default font-size, text will overflow and break the layout.
  • Relatedly, avoid using px instead try to use em or rem to improve accessibility. Here is a great resource on YT for that: https://www.youtube.com/watch?v=dHbYcAncAgQ
  • You can add a cursor: pointer; to your button to indicate the user that it is a clickable area.

  Hope you find this feedback helpful!

  0