Design comparison
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
main
element.
More Info:📚
- Your image needs an alt tag. Inside the alt tag should describe what the image is; they need to be readable. Assume you’re describing the image to someone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The
alt tag
description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a
paragraph
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1 - To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
- @Nadine-GreenPosted almost 2 years ago
HEY ABHISHEK!
I previewed your site and couldn't help but notice that the hover effect was not included for the button, I have done this challenge before and I noticed that a color for the hover effect was not included in the style guide, a quick fix for this would be to just give it a darker green, you will also need to include a cursor as well, the code
cursor: pointer
will do.IF THIS WAS HELPFUL IN ANY WAY, DON'T HESITATE TO MARK IT AS HELPFUL :)
HAPPY CODING!
Marked as helpful1 - @catherineisonlinePosted almost 2 years ago
Nice! 🙌🏻
I would also add some transitions for active states (when colors change on hover). It creates more interactivity and makes the project looks cooler. Active states can be done on buttons, links, titles which act like links or anything else, you choose.
You can read more about it here, in case you haven’t done much of it: https://www.w3schools.com/css/css3_transitions.asp
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord