Product preview card component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @arturo0427 👋, good job completing this challenge! 🎉

  I have some suggestions you might consider to improve your code:

  • Use <footer> instead of <div class="attribution"> to improve the accessibility of the website. The <footer> element contains authorship information.

  • The Add to card container should be a button and not a div element.

  • The component isn't centered correctly. You can use flexbox or grid layout to center elements. You can read more about centering in CSS here.

  • You can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query in your CSS file to modify the image.

  Example:

  <picture>
     <source media="(max-width: 894px)" srcset="./images/image-product-mobile.jpg">
     <img src="./images/image-product-desktop.jpg" alt="your alt text">
  </picture>
  

  • The cart icon is for decoration purposes only, so it can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:

  <img src="images/icon-cart.svg" alt aria-hidden="true">
  

  • You could use the <del> tag to display the old price:

  <del>
     <span class="sr-only">Old price: </span>$169.99
  </del>
  

  Note that I added the <span> with the sr-only class to the del element, this will provide more information about what your old price is about.

  The sr-only class is a class that you can add to hide content visually but is only visible to screen-readers.

  More information here.

  I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  3