Skip to content
Submitted 3 months ago

Product-preview-card-component

Ricardo Alberto Carrero Bator•160
@rc-0105
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Im proud that i could finisht it, i thought that i would never get it but i seek other resources and make it. The next time ill look the movil first aproach to make the code.

What challenges did you encounter, and how did you overcome them?

All that was related to responsiveness, ad first i make a project with fixed widhts, hights, paddings, etc, i roll back and seek for resources to know to make a responsive web site and find the relative units, the percentage widhts and that stuff that make me progress on the challenge.

What specific areas of your project would you like help with?

Any kind of help its welcome, if you think that the responsiveness could be better done or the markup or something else ill be pleased to hear. :-)

Community feedback

  • Andrey•2,550
    @dar-juPosted 3 months ago

    Hello Ricardo Alberto Carrero Bator!

    I see you have knowledge of how to layout correctly, such works are much more interesting to look at )

    There are several points that I would like to dwell on:

    • you do not need to use the line
    <source srcset="./images/image-product-desktop.jpg" media="(min-width: 586px)">

    since the desktop image is assigned in the <img> tag

    • icon-cart.svg is not a content image, but a decorate icon, it must be connected it in the CSS via background-image
    • do not use spaces in P E R F U M E there is a CSS property for this letter-spacing, the same is text-transform: uppercase;
    • you assigned classes to the titles, but for some reason you do not use them in the CSS
    • do not use rem if it has fractional numbers, the code is difficult to read
    • Add to Cart is a button, not a link, it is button, and the text has a weight of 700
    • for the beauty of the hover, add smoothness to the .add-to-cart class line: transition: background-color 0.3s ease-in-out;

    Otherwise, everything is cool! Good luck with the development!

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord