Product Preview Card Component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Sara Dunlop, congratulations for your new solution!

  🎉 Nice solution and nice code! I can see that you paid a lot of attention to your code/design. If you don’t mind I’ve some tips for you:

  You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture> instead of <img> wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  A best practice to have all the image inside the container scaling and respecting the size of the container, you need to add max-width: 100% and add alsoobject-fit: cover to make the image auto-crop when resizing inside the column:

  img {
      display: block;
      object-fit: cover;
      max-width: 100%;
  }
  

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  Sara Dunlop•430

  @RiscloverPosted about 2 years ago

  @correlucas

  Hi Lucas,

  I appreciate the kind words and the advice, which I was totally down to take and implement into my code to see how it worked out. However, I ran into a bit of trouble.

  I tried setting the main image as the desktop version and the source image as the mobile version. How would I go about setting the correct class/attributes on the source image? Like, for example, setting the border-radius properly and such.

  Thanks!

  0