Product Preview Card Component

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  Hey, You are using variables correctly, I do not see an issue here, Can you elaborate some more? Great job with this solution you should be proud, A few things I noticed,

  • Below 360px screen size your component disappears,
  • Missing a <meta> description tag for SEO purposes,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • @media should also be in relative units like rem or em,

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  1

  ---

  

  Abasifreke Jimmy•150

  @Abas-codePosted about 2 months ago

  Thank you @Stroudy for the valuable tip on making use of responsive units instead of absolute unit. I guess I've become too familiar with pixels. Again, thank you very much.

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Hey @Abas-code, We have all been there, We are all learning! You got this! 💪

  Marked as helpful

  1