Design comparison
Solution retrospective
Hello there ๐
This challenge was good, enjoyed it. I used CSS grid for the first time.
Question:
The image is a bit dark in the design, how do you add the dark overlay over the image?
Appreciate any feedback. ๐
Community feedback
- @correlucasPosted about 2 years ago
๐พHello @ezra-ramatong, Congratulations on completing this challenge!
Your solution its almost done and Iโve some tips to help you to improve it:
Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the
<picture>
tag instead of importing this as an<img>
or using a div withbackground-image
. Use it to place the images and make the change between mobile and desktop, instead of using adiv
orimg
and set the change in the css withdisplay: none
with the tag picture is more practical and easy. Note that for SEO / search engine reasons isnโt a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device desktop + mobile.Check the link for the official documentation for
<picture>
in W3 SCHOOLS:https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture> <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;"> </picture>
๐จโ๐ปHere's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1
โ๏ธ I hope this helps you and happy coding!
Marked as helpful0 - @K-ZimnyPosted about 2 years ago
You can create a psudo-element for the img (::after) that is the same height and width as the image. Then you can add a dark background and mess with the opacity.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord