Product preview card component

Community feedback

• 

  Douo•940

  @DouooPosted 12 months ago

  Hey Veronica, just came across your solution. Impressive - I like your solution and even better, I like your confidence. You did a very good job. A small suggestion though - in your <article> tag you gave it a fixed width of 21.4375rem, by doing this you are taking away the responsiveness and setting a constant width that stays the same for a certain condition (in your case responsiveness). Now there is no problem with this as long as it gets the job done but its not as flexible as it should be. Here is a better solution for it:

  article {
    width: min(21.4375rem, 85%); 
  ...
  }
  

  This will give it a max width of 21.4375rem but will keep the width at 85% in case its lower than the given width. By doing this you won't need to change or adjust the width property in different media size. Overall, you have done a pretty solid job for this challenge and seeing from your code I have no doubt that you will progress even better with time. Keep up the good work Veronica 👍🏽

  0

  ---

  

  Veronika•110

  @designverPosted 12 months ago

  @Douoo Hi, thank you for the comment! Responsiveness is a topic I haven't thoroughly studied yet, so I understand that there are other ways to solve it. In the next project, I'll try working with your suggestion :)

  0
• 

  abiskar100•100

  @abiskar100Posted 12 months ago

  @designver hey you did a wonderful job there but you missed the cart svg. <svg src="" /svg> . If you adjust the gaps on text-context it will be perfect .

  0

  ---

  

  Veronika•110

  @designverPosted 12 months ago

  Hello, thank you for the comment. The SVG image was present in the code and was functional, but the issue occurred during the upload to GitHub. Everything has been fixed :)

  0