@bccpadge
Posted
Hello @ouariadam. Welcome to Frontend Mentor Community !!!π
I have few tips to improve your solution.
HTML π:
- Wrap your content using
main
tag because every website should have at least one landmark
<body>
<main></main>
<footer></footer>
</body>
CSS π¨:
- Font size shouldn't be pixels because it is inaccessible for users who want to change the font size in their browser setting.
More infoπ:
Font size shouldn't be in pixels
- I see your product preview card component is not centered in the page.
- You can use Flexbox or CSS Grid
Flexbox
body{
display:flex;
justify-content:center;
align-items:center;
min-height:100vh;
}
CSS Grid
body{
display:grid;
place-content:center;
min-height:100vh
}
- To make this component responsive you would need to add media query
- If you haven't learned responsive design the best project to start on Frontend Mentor is the qr code component challenge.
Hope this helps you and don't hesitate to reach out to me if you have any questions
@ouariadam
Posted
thank sooooo much , i appreciat your comment , i'll do my best--π@bccpadge