Skip to content
Submitted over 2 years ago

Product preview card component

Ibrahim San•230
@ibra-san
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

. The area I am unsure of is the compatibility with different screen sizes. Also not sure how professional is my code and if I have applied good coding practices or not.

Community feedback

  • Francis Wafula•80
    @franco2kePosted over 2 years ago

    Hi, Just had a look at your project. Great work, I like your classnames, you got BEM methodology on lock. Two suggestions;

    • For the card details container 'card__perfume--details' setting justify-content to 'space-between' would have been easier than applying margins to all the child elements in my opinion. Not adding custom margins also helps with resuability in other future projects.
    • See the frontend mentor 'accessibility' report for additional tips if you haven't. Otherwise, good stuff.
    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord