product preview card component

Community feedback

• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋🏻, some of this may interest you for future projects:

  • Headings shouldn't be used to make text big or bold, that's what CSS is for. Also, using more than one <h1> is allowed but is not considered a best practice, so if you are going to use more headings maybe it would be better to use an h2 and so on.

  • It could be better to use the <del> element for the old price because the way you did it, a screen reader user won't know it has a strikethrough.

  • Consider using some CSS reset as a good practice to have a clean starting point and reduce differences between browsers. An example of CSS reset here 🔎

  These are some very basic and useful ones to start:

  * {
  box-sizing: border-box;
  margin: 0;
  padding: 0;
  }
  

  • Think about using relative units since they are better for scalable layouts. Something simple to start with would be to convert to rem (1 rem equals 16px by default), consider this suggestion especially for the font-size.

  I hope it’s useful : )

  Regards,

  Marked as helpful

  0