Product preview card component [Naimur]

Community feedback

• 

  P

  Krishna Vishwakarma•1,390

  @KrishnaVishwakarma1595Posted about 1 year ago

  Hi, @NaimurRahman00*

  Nice solution! Congrats on completing the challenge. I've some points to mention -

  • For the section card class .card you can remove the height.
  • For the image .card .lap you can provide height: 100%, with the above change.
  • On add to cart button hover state the button background goes white, which makes the button almost hide. You provided the color but I think that's not defined as a CSS variable.

  button:hover {
      background-color: hsl(158, 36%, 50%);
      cursor: pointer;
  }
  

  You can change the color as per the need.

  • Also, for main product image tag the alt attribute is empty, I think we should provide some genuine text. For the icons it is fine to have alt="" empty.

  • For your footer attribution I don't know you did it purposely to the right. That's okay. But, I think you can keep it center below the container.

  Hope this point will help you.

  Happy Mentoring

  Marked as helpful

  1

  ---

  

  NaimurRahman00•180

  @NaimurRahman00Posted about 1 year ago

  Hello sir, (@KrishnaVishwakarma1595)

  Thanks for your precious time.

  • In the class .card I removed the height and .card .lap I provided the height: 100%
  • Also I fixed the button.
  • In the alt="" I provided some text.
  • In this footer attribution, I thought it will look better, but now you can check it.

  Best regards , Naimur

  1

  

  P

  Krishna Vishwakarma•1,390

  @KrishnaVishwakarma1595Posted about 1 year ago

  **Hey, @NaimurRahman00 **.Don't call me sir 😅, Krishna would be fine. It is good to see you implemented the changes and make your solution perfect. Good Job!

  Keep Mentoring & make awesome solutions

  1

  

  NaimurRahman00•180

  @NaimurRahman00Posted about 1 year ago

  Okay! Okay! Thank you, Mr. Krishna ji.

  1

  

  P

  Krishna Vishwakarma•1,390

  @KrishnaVishwakarma1595Posted about 1 year ago

  @NaimurRahman00 You're welcome.😅

  0