Product Preview card component

Community feedback

• 

  Pulkit saxena•890

  @Pulkit-s21Posted about 2 years ago

  @MichalBednar There are few bugs in the code.

  1. I see you used fixed height and width for the main which I must tell you is a wrong approach. Don't fix the height and width. Put the image and text in a container and set a max:width to the container.
  2. Place the picture tag in a div of its own and set the div to flex:1 and the text to do the same as well so they take equal space on desktop version.
  3. Your button overflows from the div because you set a fixed height and width to it. Always use width and assign padding and not use height unless its absolutely necessary.
  4. Try reducing the font-size of h1. I think its too big right now but just a suggestion.

  I have also done this challenge so if you like you can view my solution for reference

  Marked as helpful

  0