suhayb jirde• 1,050
@suhaybjirde
Posted
perfect
1
starryrobot• 200
@starryrobot
Posted
@suhaybjirde Thanks!
0
Design comparison
Solution retrospective
Hey all, hope everyone is well! I actually found this project more challenging than the "Junior" news homepage challenge I did yesterday and so this challenge humbled me! I got stuck trying to make the layout mobile ready. Apart from that, everything was basic styling.
Please let me know what you think and 100% welcome all feedback, criticism etc! Thanks :)
Community feedback
バレンタイン 😈• 64,190
@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the
mainelement.
More Info:📚
- Since the images in this component add value and serve a purpose (displaying the product), it is best to use the
Pictureelement and not thebackground-imageproperty, as it will to use different images during different breakpoints.
Here is an example of how it works: EXAMPLE
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
delelement and inside it you will add aspanelement with ansr-only classthat will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
0
starryrobot• 200
@starryrobot
Posted
@vcarames Thanks for your feedback. I will try the picture tags out! I agree that its important to include semantic tags but in this case I was creating a component so including semantics that are usually reserved for the main page didn't make sense to me as this is a component, not a full HTML document.
Thanks!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord