Product Preview Card Component

Community feedback

• 

  suhayb jirde•1,050

  @suhaybjirdePosted almost 2 years ago

  perfect

  1

  ---

  

  starryrobot•200

  @starryrobotPosted almost 2 years ago

  @suhaybjirde Thanks!

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • Since the images in this component add value and serve a purpose (displaying the product), it is best to use the Picture element and not the background-image property, as it will to use different images during different breakpoints.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  0

  ---

  

  starryrobot•200

  @starryrobotPosted almost 2 years ago

  @vcarames Thanks for your feedback. I will try the picture tags out! I agree that its important to include semantic tags but in this case I was creating a component so including semantics that are usually reserved for the main page didn't make sense to me as this is a component, not a full HTML document.

  Thanks!

  0