Submitted over 1 year ago
Product Preview Card component - Mobile First approach
@guillermopaniaguasilva
Design comparison
SolutionDesign
Community feedback
- @VladmidirPosted over 1 year ago
Some of the things I noticed,
- Your HTML should be enclosed by landmarks to convey the structure of the page. You should change the
<div>
container that encloses all the content to a<main>
. - I suggest you use the tag
<sup>
for the old price superscript. - You may want to use the HTML
<picture>
element to responsively change the image, instead of changing it with CSS. - I suggest you put the perfume name inside the heading element
<h1>
.
Hopefully, this is helpful. I am new to front-end, but that is some advice I have been getting myself.
0 - Your HTML should be enclosed by landmarks to convey the structure of the page. You should change the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord