Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FM perfume design (my first project)

@abrankovan

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone,

This is my first project on frontend mentor, and I'm very excited . Any feedback is welcome. :)

Community feedback

@RMI11

Posted

Hello there! 👋

Congrats for completing the challenge! I'm glad I can learn from you! 🙌

Happy holidays! 🎉✌

Marked as helpful

0

@abrankovan

Posted

@RMI11 Thank you Rajko :)

1
Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="main-part"> with the main tag and <h4> with p to fix the accessibility issue. for more on semantic html visit https://web.dev/learn/html/semantic-html/ You forgot to add the mobile-image for the mobile design.

Give .main-part a height of auto to prevent the content from overflowing when the screen is reduced. Increase the width value of .main-part . e.g .main-part{width:600px}

Give .image a width of 100% and add display: block; to .img-wrapper.

Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

Hope am helpful

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0
Nikola D 1,450

@NikolaD93

Posted

Hello there! 👋

Congrats for completing your first challenge! 🙌

I have 2 suggestions for you:

1.Make sure to provide alt attribute to your <img/> tag.

2.Try to use <del></del> tag for the old price, instead of styling it in css.

Here is the link for <del></del> 👇 https://www.geeksforgeeks.org/html-del-tag/

Hope this was helpful for you, if it was mark it as helpful 🙏

Have a nice one! 🎉✌

Marked as helpful

0

@abrankovan

Posted

@Nikola1232456 Thank you a lot Nikola, this is really helpful for me :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord