Product preview card component main with flexbox
Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <div class="container"> with the main tag and <p id="gabrielle"> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
Add the language attribute to the html
<html lang= " en ">
to fix the error issue.there is no need to style .container rather give a fixed max-width value which will be the total max-width of #right and #left and display : flex. and give #left and #right a width of 50%
.container{ max-width:500px; display: flex; }
To center .container on the page using flexbox or grid, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
USING FLEXBOX: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
USING GRID: body{ min-height: 100vh; display: grid; place-items: center; }
Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
in the media query give #right and #left a width of 100%.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord