Submitted about 1 year ago
Product Preview Card Component Main Project
@mericcintosun
Design comparison
SolutionDesign
Solution retrospective
Thanks for Frontend Mentor Project!
Community feedback
- Account deleted
Nice component! Here are some tips:
- it's a bit small on a mobile device due to the fixed widths
- use a parent element instead of main, this makes the code not really reusable
- Nice use of the variables and separating the hsl values from the hsl code variables. However the variables of the hsl colors a bit hard to read when they are this short, try using more explainable variables.
Marked as helpful0@mericcintosunPosted about 1 year ago@developer-ruben Thanks for the feedback! If by fixed width you mean percentages, what can I use instead? Secondly, I would like you to explain the second point a bit more.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord