product-preview-card-component-main

Community feedback

• 

  Andi Fachriansyah Dwipangga•710

  @fachridpPosted 3 months ago

  Hey mate, you have done a great job on this challenge, almost perfect tho, but there is ain't perfect in this world hehe.

  Here's some advice from me based on what i'm see :

  1. Let's start from your html structure. Try to implement a semantic HTML from now on (You can read from this article: Semantic HTML or other resource with semantic html topic ).
  2. I see you gave your element like this div class="Main". You don't have to write like that, you can write <main></main> instead. Read the article that i give you to understand about semantic html and try to implement them from now on.
  3. Put your <img /> tag inside a div.
  4. You must give your html elements with make sanse classes.
  5. In your text0 class, you should not do like this P E R F U M, but give him style property namely letter-spacing: your_value_here instead.
  6. Give a style property line-height : your_value_here to your text2 class, to give those line paragraph spacing with vertical axis (up to bottom).
  7. I'm not see your bacground-color: white when i resize my browser to mobile screens.

  And i think that's it from now. Hope you doing well in your next challenge and have a nice day mate.

  Marked as helpful

  0

  ---

  

  youssefcharfeddine•110

  @youssefcharfeddinePosted 3 months ago

  @fachridp thanks for all your advice bro

  0