Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
i'm proud that my skills in html and css are getting better i still have a little trouble in responsive web desgin but i will work for it ..
What specific areas of your project would you like help with?everything especially responsive web desgin and thanks ...
Community feedback
- @fachridpPosted 4 months ago
Hey mate, you have done a great job on this challenge, almost perfect tho, but there is ain't perfect in this world hehe.
Here's some advice from me based on what i'm see :
- Let's start from your html structure. Try to implement a semantic HTML from now on (You can read from this article: Semantic HTML or other resource with semantic html topic ).
- I see you gave your element like this
div class="Main"
. You don't have to write like that, you can write<main></main>
instead. Read the article that i give you to understand about semantic html and try to implement them from now on. - Put your
<img />
tag inside a div. - You must give your html elements with make sanse classes.
- In your text0 class, you should not do like this P E R F U M, but give him style property namely
letter-spacing: your_value_here
instead. - Give a style property
line-height : your_value_here
to your text2 class, to give those line paragraph spacing with vertical axis (up to bottom). - I'm not see your
bacground-color: white
when i resize my browser to mobile screens.
And i think that's it from now. Hope you doing well in your next challenge and have a nice day mate.
Marked as helpful0@youssefcharfeddinePosted 4 months ago@fachridp thanks for all your advice bro
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord