Product preview card component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @oyindamoladekeye, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Improve the card's overall look by adding the rounded borders to the component and also the image using border-radius: 15px

  • Add rounded borders to the left side of the image with border-radius: 15px 0px 0px 15px;
  • Then do the same thing for the component but in the opposite borders border-radius: 0px 15px 15px 0px;

  Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  Adekeye aishat•130

  @oyindamoladekeyePosted about 2 years ago

  @correlucas thanks for the reply I tried the picture element but I couldn't resize the image for the mobile

  0