Product preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The alt tag description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0
• 

  Jake Samuels•780

  @jake4369Posted almost 2 years ago

  Hi, you solution looks great congratulations!

  One way to handle responsive images that change is to use the <picture></picture> tag instead of using background images. You can specify multiple images and media queries inside the picture tag, and the images will respond and change whenever you resize the browser window. Using means you don't have to set the display to none/block on the images you don't need at certain sizes.

  Check out w3Schools if you'd like to learn more about how to use the picture tag, it's really easy to use once you've had a bit of practice with, you'll begin to use it over and over again doing the challenges of Frontend Mentor so it's a great tool. to have.

  Here's the link:

  https://www.w3schools.com/tags/tag_picture.asp

  I hope you find this useful, happy coding ☺️

  0

  ---

  

  Harun Korkmaz•40

  @WiddedPosted almost 2 years ago

  @jake4369

  I didn't know that. Thanks for the information that you give to me.

  I'm going to be more careful after that.

  0