バレンタイン 😈• 64,190
@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
Unfortunately, your content is not complete since it is not responsive, which is a requirement for this challenge. A media query will help. I attached a link in the bottom to better help you.
- The image’s
alt tagdescription needs to be improved upon. Assume that you are describing the image to a someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints. The
pictureelement will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
delelement and inside it you will add aspanelement with ansr-only classthat will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁
Marked as helpful
0
バレンタイン 😈• 64,190
@VCarames
Posted
- Your
CSS Resetis being underutilized. To fully maximize it, you will want to add more to it.
Here are some examples that you can freely use:
- For improved accessibility 📈 for your content, it is best practice to use
remfor yourfont-sizeand other property value. Whileemis best formedia-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.
- Your content is not fully responsive. Here is a link to Google Developer’s site that will teach you how make it 100% responsive:
0
