Product preview card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  MrDeveloper01010•240

  @istfredyPosted over 1 year ago

  @0xAbdulKhalid Hello and Thank you very much, I learn a few things new :)

  0
• 

  Bader Idris•2,880

  @Bader-IdrisPosted over 1 year ago

  some advice on fixing your prices.

  you can put both prices into a div and give that div display: relative, and its children position: absolute;, then you can modify top and left of these prices, especially the crossed one. I hope it's helpful.

  to Summarize:

  div.parent {
    display: relative;
  }
  div.parent .children {
    display: absolute;
  }
  div.parent  :last-child {
    left: 30px ;
  }
  

  0

  ---

  

  MrDeveloper01010•240

  @istfredyPosted over 1 year ago

  @Bader-Idris Thank you, But i hadn't seen on the design that in fact the two prices are perfectly on the same line.😅 In the future I will observe the design more carefully.🤠

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted over 1 year ago

  @Bader-Idris @ MrDeveloper01010

  There’s no need to use absolute / relative in this challenge. Especially for the prices. Just place both prices inside a div and apply flex along with align-items: center and finally give it a gap.

  1

  

  MrDeveloper01010•240

  @istfredyPosted over 1 year ago

  @vcarames This is true :)

  0