Product preview card component

Community feedback

• 

  Adriano•38,060

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Milan, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  For the user to know that an element is clickable we need to use the attribute, cursor with the value pointer.

  button {
      cursor: pointer;
  }
  

  I noticed that you made your entire code using divs! this is not a good practice since div has no meaning, to improve the structure of your code we can use semantic elements that have meanings, not only for us who are developers, but also for screen readers, that is, a person who uses tools to browse the web, can better understand the content if our code is well written with semantic tags and some other features to improve accessibility!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Milan•120

  @pjevicPosted almost 2 years ago

  @AdrianoEscarabote Hi, Adriano! It's good to hear from you! I was actually looking at your page earlier! I noticed I forgot to implement the active state, then I made a change - but I'm so new with git that I have no idea where that change went, it's certainly not visible at GitHub. I guess, I should work on that, too. :)

  Thank you for your time.

  1