Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <h2> with <h1></h1> , <h4> with <h2></h2> and <h6> with <p></p> to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/
There is no need to give the body a width value and a flex-direction of column to center the main. replace height: 100vh with min-height :100vh
For the desktop design give the main a fixed width instead of a percentage width value. e.g width:600px; There is no need to give the main a height value and a min-height value.
there is no need to give .main-left and .main-right {flex: 1}. Reduce the padding of btn e.g: padding: 1rem 5rem; You for got to add a media query for the mobile design. in the media query the main a percentage width of 80% or 90% and a flex-direction: column
Hope am helpful. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord