Design comparison
Solution retrospective
hope this is better
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- To center you content to your page, add the following to your Body Element:
body { min-height: 100vh; display: grid; place-content: center; }
-
Remove all the individual
border-radius
you added and instead place it to the Body Element along withoverflow: hidden
. -
Remove all the
<br>
elements you added, they are unnecessary. -
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
If you have any questions or need further clarification, let me know.
- You wan to build the component with either CSS Flex or Grid not float.
Happy Coding! 👻🎃
0 - @AlexAgustiniPosted about 2 years ago
Hey man, nice project, just a little tip: in the "perfume" heading at the top of the card, you could add a "letter-spacing" property to space the letters, i guess it would be like 1 or 2 px, so it gets closer to the original design
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord