Product preview card component

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Cool solution!

  To improve semantics, make sure to wrap the entire code in the main tag not including header or footer tags. It will help to remove report issues and improve accessibility as well.

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  Marked as helpful

  1

  ---

  

  Lagan Gupta•30

  @lagan-devPosted almost 2 years ago

  @catherineisonline Thank u so much for the feedback.

  0
• 

  Amanda Buttineau•200

  @ab1820Posted almost 2 years ago

  Hey there!! Here are some of my insights:

  1. You should always try to remember to add a README page, a screenshot of your challenge would be a nice touch, also the read me allows you to explain how you went about doing the challenge and applying different styles, etc.

  2. Just from looking at the preview, I can see that you did not apply any padding or margins which in turn makes your design look a little more squished than the challenge. Try playing around with those to see the outcomes! 3.Colors and font are spot on!! :)

  Otherwise I dont see any real issues with your design just besides the padding and margin issues. NBD! Practice, and learn! :) You also managed to get the responsivness working which is awesome!

  Happy Coding! :)

  Marked as helpful

  1

  ---

  

  Lagan Gupta•30

  @lagan-devPosted almost 2 years ago

  @ab1820 Thank u so much for the feedback.

  0

  

  Amanda Buttineau•200

  @ab1820Posted almost 2 years ago

  @lagan-dev no problem!! :)

  0