Design comparison
Solution retrospective
how can I improve this CSS code? how's the responsive design? could it be better? what about my HTML structure?
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
To center . box on the page using flexbox, add min-height:100vh and align-items: center to .container.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord