Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

@MoAfi12

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Product preview card component

'My Github'

Community feedback

@EngProvidence

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you. CSS🏷️: I WILL LIKE TO GO STRAIGHT TO THE POINT your image -product image is not really responsive when resizing the screen. you can fix this using css by add an id here

<div class="column-one"> <img src="images/image-product-desktop.jpg" alt="image-product" id="product" > </div> then go to css

your code .column-one img{ height: 480px; // remove this line. width: 360px; border-top-left-radius: 10px; border-bottom-left-radius: 10px; }

add

#product{ height:100%!important;} so as to adjust the image with the column size

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0
Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="container"> with the main tag and <h4> with <p> to make the content accessible. click here for more on web-accessibility and semantic html

Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

To center .container on the page using flexbox or grid instead of margin,

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
  • USING GRID: add min-height:100vh; display: grid place-items: center to the body
body{
min-height: 100vh;
display: grid;
place-items: center;
}

For a responsive content, give .container a fixed max-width value instead of a percentage width.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

@MoAfi12

Posted

thank you guys so i fixed its some problem the browser

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord