Design comparison
SolutionDesign
Solution retrospective
please give me a few suggestion to improve my css
Community feedback
- @hatemhenchirPosted almost 2 years ago
Hey Cyber12341, how are you ? I really liked the result of your project, but I have some tips that I think you will enjoy:
- All the document need title to aid in navigation. You can do it like this
<head<title>Frontend Mentor | Product preview card component</title></head>
- the tag HTML must have a Lang attribute like this
<html lang="en">
- The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include span element with an sr-only text explaining that this is the old price.
The rest is great!
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1 - All the document need title to aid in navigation. You can do it like this
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord