Training-product-preview-card-component-main

Community feedback

• 

  Kehinde Hussein, Fasunle•190

  @FasunlePosted almost 2 years ago

  Hey @Devalito67,

  It is my pleasure to review this project. You did an amazing job. Since you want a better job, here are a few tips that would make you result even better:

  • I find out that you are styling html elements directly e.g:

  
  h3 {
    font-weight: 500;
    font-size: 12px;
    letter-spacing: 5px;
  }
  

  This is not considered a good practice and it is pretty painful to understand the styles when you revisit your code in future. Instead,

  • reset the default styles: https://piccalil.li/blog/a-modern-css-reset/ to prevent inconsistencies across browsers.
  • use class instead of html elements e.g . heading instead of h2
  • BONUS: I would also suggest that you look into the BEM Methodology. This will make your work clean and fast.

  If you find this useful, kindly mark it as useful.

  Happy coding

  Marked as helpful

  1

  ---

  

  Devalito67•40

  @Devalito67Posted almost 2 years ago

  @Fasunle Thanks for your help, i have update my work and try to apply your advices to do a better job, i hope i did it...

  1

  

  Kehinde Hussein, Fasunle•190

  @FasunlePosted almost 2 years ago

  @Devalito67 you can invite me to your project on GitHub... It's my pleasure to help once again.

  Here is my page link:

  https://github.com/Fasunle

  Marked as helpful

  0
• 

  Tomek•240

  @qntekPosted almost 2 years ago

  Hi there. Well I think that You should start learning html / css first before using bootstrap.

  Also try to apply some media query to that project so it could display on mobile devices as well.

  Good luck.

  0