Skip to content
Submitted over 1 year ago

Product preview card component

Karthik•220
@Bi-Byee
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hey guys did a new component, hope it's met up with the challenge. Could anyone recommend resources to easily understand responsive design and @media query.

Bless up, Karthik

Community feedback

  • _nehal💎•6,710
    @NehalSahu8055Posted over 1 year ago

    Hello Coder 👋.

    Congratulations on successfully completing the challenge! 🎉

    Few suggestions regarding design.

    ➨ Remove all margins from .wrapper its not a good way of centering card.

    • To properly center the container.

    • USING FLEXBOX

    body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
    • USING GRID
    body{
min-height: 100vh;
display: grid;
place-items: center;
}

    ➨ Use Semantics for the proper design of your code.

    <body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribution` inside `footer`
</body>

    ➨For non-decorative images give meaningful and descriptive alt like alt= "Gabrielle chanel Perfume product of london".

    ➨ Every site must have one h1 element describing the main content of the page.

    • So, Add a level-one heading instead of h5 to improve accessibility.

    ➨ Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

    link.

    ➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.

    I hope you find this helpful.

    Happy coding😄

    1
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    PiCTURE TAG 📸:

    • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.
    • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.
    • Example:
    <picture>
<source media="(max-width: 768px)" srcset="small-image.jpg">
<source media="(min-width: 769px)" srcset="large-image.jpg">
<img src="fallback-image.jpg" alt="Example image">
</picture>
    • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.
    • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user
    • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0
  • Loai Esam•670
    @LoaiEsam37Posted over 1 year ago

    Wow, you're a coding wizard! Your solution is so elegant and efficient. and also if you add these properties to your code it will be better.

    body {
display: flex
justify-content: center
align-items: center
}

    this will make you .wrapper element in the center of the page.

    happy coding !!!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord