Product Preview Card Component using CSS

Community feedback

• 

  Eileen dangelo•1,600

  @EileenpkPosted almost 2 years ago

  Hi Richard,

  Your project is very really good! to answer your question about using floats, looking at your code I saw that you already had most of the code needed to use Flexbox instead of floats.

  I thought it might be helpful for you to see the actual changes that would need to be made so I made a pull request on GitHub. Here is what needed to be changed.

  • Comment out or remove all floats
  • Uncomment three lines of code on the .card that you already have in the project, and in doing so will fix the layout.
  • Add flexbox to the body to center the card on the page.
  • Change some of the HTML tags to be more semantic making the code easier to read, this also gives it better accessibility for people who use screen readers to surf the web.

  Cheers! If you found this helpful please mark it as such :)

  • Let's connect on LinkedIn! - @Eileenpk

  Marked as helpful

  1

  ---

  

  Richard Tom•80

  @CryptoFallenPosted almost 2 years ago

  @Eileenpk Thank you so much for looking at my code, I really appreciate it. I was definitely thinking of using flexbox, but for some reason forgot.

  Still new in this coding journey and appreciate the changes you have made. I merged your pull request, it was very helpful.

  Will connect with you on LinkedIn as well, many thanks once again. :)

  0

  

  Eileen dangelo•1,600

  @EileenpkPosted almost 2 years ago

  @CryptoFallen I'm so happy to help! I accepted your request on LinkedIn.

  Also if you are looking for a very good resource for self paced learning I can't recommend Scrimba enough. They have a bunch of free courses that are very good. I got a front end certificate through them a while ago. It really helped me get better at coding.

  If there is anything else I can help you with send me a message on LinkedIn!

  Marked as helpful

  1

  

  Richard Tom•80

  @CryptoFallenPosted almost 2 years ago

  @Eileenpk Thank you for the advice, will definitely look into Scrimba, I've been utilizing CodeCademy Pro for my learning, the only problem with the learning resources is they hold your hand too much and do not enough letting you figure things out or do enough practice to get better at the coding side, I guess that is where it is important that I have learned to look at other peoples repositories and see how they came up with their solutions that may be more efficient.

  Good luck with your coding journey I see you are changing industries from your LinkedIn when this coding path happens, which is great.

  0