Product preview card component (HTML/CSS)

Community feedback

• 

  solitary_coder•1,000

  @kabir-afkPosted over 1 year ago

  Hey!! Look there isn't much for you to improvise on , you know how to name elements making your CSS look pretty clean...you are writing semantic html , you are using appropriate units at some places, you are aware of the picture tag....but I'd still recommend if you could could avoid using pixels for specifying dimensions. It's better if you go with % . Similarly for padding use ems , for font size you've already used rem which is great.. The more relative units the better....your perfume image is lil cramped up..it's matching the height but not the width....well its not like you've applied any CSS to it, but if you do , try

  img:{max-width:100%}

  and then enclose your image inside a div tag , what this will do is whenever you control the width of your div tag your image's dimensions will change simultaneously...keep coding !!!

  Marked as helpful

  0

  ---

  

  Matthieu•180

  @Matt971xPosted over 1 year ago

  @kabir-afk Thank you very much for you answer , i apriciate it ! thanks for your advices i'll try to apply them for other challenges ! thanks a lot !

  0