Product Preview Card Component HTML, SCSS

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  You smashed this challenge, 100 in all four categories on lighthouse and all the other good stuff! One thing I noticed

  • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

  .card__description {
      color: var(--dark-grayish-blue);
      font-size: .881rem;
      line-height: 1.438rem;
  }
  

  Other than there I cant find anything wrong at all! Great job!

  Marked as helpful

  0