Product Preview Card Component - HTML, LESS, BEM

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 8 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image,

  @media (min-width: 38em) {
    .product-card__image-wrapper-mobile {
      display: none;
    }
  }
  
  @media (min-width: 38em) {
    .product-card__image-wrapper-desktop {
      height: 100%;
      display: block;
    }
  }
  

  ---

  • So let me introduce the picture element., The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
    <source media="(max-width: 768px)" srcset="small-image.jpg">
    <source media="(min-width: 769px)" srcset="large-image.jpg">
    <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  P

  Steve Xero•210

  @stevexeroPosted 8 months ago

  @0xabdulkhalid Woah thanks so much Abdul! I did not know! I will be incorporating that for sure!

  0
• 

  Mirjax2000•680

  @Mirjax2000Posted 8 months ago

  can you put on the scale sass and less and tell what is better? Also another preprocesor is stylus. Will you gona try it?

  Myaby in couple years, we dont need any preprocesors at all, all best funkctions are alredy in css: variables, nesting, and many more will come.

  Marked as helpful

  0

  ---

  

  P

  Steve Xero•210

  @stevexeroPosted 8 months ago

  @Mirjax2000 I've never heard of Stylus, will definitely look into it!

  Personally, I like Sass better! It's fun to write! Less is cool if you like writing more pure CSS, but you're right about vanilla CSS incorporating more of the same techniques as a lot of these preprocessors. I also really enjoyed Tailwind on that other project, it kept me from jumping back and forth through my files so it was really efficient.

  0