Product preview card component (Html, Css, Mobile First)

Community feedback

• 

  Abdallah Aminu Daneji•240

  @waad2lfPosted over 1 year ago

  Well done your solution looks awesome, But your work looks a little bigger than the design, It's very good to compare your work with the design. Also, the footer (challenge by.....) should be outside and under the project.

  Marked as helpful

  1
• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋🏻, in case you want to take a look:

  HTML / ACCESSIBILITY:

  • It would be better to capitalize 'Perfume' with CSS (using text-transform: uppercase;) and not in HTML. Some screen readers will read out uppercased text as individual letters.

  • The icon is a decorative image and therefore need an empty alt attribute to be ignored by a screen reader.

  • Consider leaving the <footer> outside of the <main>.

  CSS:

  • If you look between 700 and 760px there is a white space below the image, you can easily fix it with height: 100%

  I hope it’s useful : )

  Regards,

  Marked as helpful

  1
• 

  DnlTngl•140

  @dnltnglPosted over 1 year ago

  @fernandolapaz Thankyou My friend!

  1