Skip to content
Submitted about 2 years ago

Product preview card component HTML CSS flexbox

Ashitaaka•60
@Ashitaaka
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I struggled to understand how to make my image fill the entire div

Community feedback

  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi Ashitaaka, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
  • birkaany•240
    @birkaanyPosted about 2 years ago

    Hello, firstly congrats for completing the challenge!

    I see that your image looks fine yet you could get a cleaner code.

    Things that you can improve;

    • Your columns' width isn't equal. You can solve that by defining child elements' flex-basis value to 50%.
    • Your img element wrapped inside picture element and another div called product_image. You don't need both, picture element is a container for img element itself. You can delete product_image div, so flex-basis:50% affects your picture element. This means, your img element's container is limited with 50% width.
    • After doing this, all you need to do is setting img element's width to 100% (so its width is limited to parent element's width, which is 50%) and set display:block.

    I hope this helps a bit. Have a good day!

    0
    Ashitaaka•60
    @AshitaakaPosted about 2 years ago

    @birkaany yes, but look now that I changed the min-width for the responsive, I do have a problem with my image in desktop mode. When its not wide enough I do have blank on top and bottom of my image.. How could i get rid of it..? -Source code : https://github.com/Ashitaaka/Challenge-4-modify.git -Live site : https://ashitaaka.github.io/Challenge-4-modify/

    0
    birkaany•240
    @birkaanyPosted about 2 years ago

    @Ashitaaka As I checked on different dimensions, I thought it's resolved but I was mistaken. Sorry for that. Something is wrong but I couldn't figure out yet, I'll edit my reply if I do.

    0
    birkaany•240
    @birkaanyPosted about 2 years ago

    @Ashitaaka okay I think I've found the issue.

    As we shrinking the window, columns' height doesn't shrink equally because the card element doesn't have a height property. Img gets shrinking cause it is fluid, but text content can't get smaller because its font sizes.

    To solve this;

    • Add height to the card element (e.g height:600px)
    • Add height to the img element (height:100%)
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord