Product preview card component, html & sass

Community feedback

• 

  P

  Srishti Chaudhary•170

  @itsmesrishtiPosted 4 months ago

  Hi, pretty good work on getting close to the design! Here a few things you could consider to improve the project or maybe apply them for your next one!

  • I see that you have used the font names but you have not loaded the fonts. You could link the google fonts and select the apt font-families and they'll give you the link codes just paste them in the head section of your html. Also when using css to set fon-family we should also provide a fallback font like serif or sans-serif along with font-family name so that if your font is not loaded the browser will use the apt font that fits your style.

  • For the image I think you should go through the resources FEM provided in the previous chapter so that you can load the different images correctly. They recommend using picture tag or srcset attr depending on the needs. Go thorugh it and do what feels right to you for the project or the coming projects.

  Again good attempt at the project! Onwards and upwards!

  0