@PPechmann
Posted
Hallo Ron!
Congrats on completing the challenge, well done!
Regarding the BEM methodology, it does get a bit confusing with the larger classnames you used for this project. I would have a bit of a hard time, if this was a big project and I had to understand the code. I highly recommend checking out this quick BEM Guide. Basically, you use (card__component), for components and (card--button) for modifiers, for example.
I also recommend working with an editor for these challenges, such as Visual Studio Code or Atom, as the website is unable to track errors properly from Codepen. You will see, that a lot of HTML and accessiblity issues are showing, when I am 100% sure there aren't as many.
Lastly, I highly encourage you to get used to working with rem and em units instead of px, as these are scalable and will make your life much easier in terms of responsivess.
Hope my quick feedback helps, and I am looking forward to more completed challenges from you!
Best Regards,
Patrick
Marked as helpful
@ron-wollschlaeger
Posted
Hi @PPechmann thanks for your help!
Regarding the BEM thing. I thought I would be using it the right way, but I used card__full-content__paragraph for example, but in this case I should have used just card__paragraph, right? It sounds easier for other people to read my code.
Yeah, I am using VS Code and I couldn't find any errors, but I am not sure if it comes only from CodePen or something I have missed.
In my next challenge I will try to use rem and em units only, and in general I will keep an eye on learning more about units.
@PPechmann
Posted
@pxMahio Exactly, the shorter you are able to keep the classnames without losing their descriptive purpose, the better.
And yes, most of the errors showing are due to codepen, as @correlucas mentioned. You will see that this will be solved, as soon as you upload your solution via Netlify free hosting, for example.
The units are mostly important for your time, as you will notice that you spend much less on getting bigger project responsive. If you use relative rem units for example, and then simply lower the font-size for the entire html document on smaller sizes, half the work is done already.
Marked as helpful