@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Apply the following code to have each side take up the equal amount.
Code:
(component-container) > * {
flex-basis: 50%
}
-
Change the
width
of the .card tomax-width 600px
to better match the FEM example. -
For this challenge you want to use the Picture Element not the Background Image Property. The Background Image Property is mainly used on decorative images
Picture Element will allow your to switch between images in different breakpoints and makes your site load faster by saving bandwidth.
Here is an example of how it works: EXAMPLE
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
Once you fix the image implementation, you will want to include an Alt text tag with them. Inside that Alt Tag you want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
Your content is not fully responsive. Here is a link to Google Developer’s site that will teach you how make it 100% responsive:
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
@DragonFireShield
Posted
@vcarames Thanks for this amazingly helpful comment! I will try to improve on this tomorrow.
@VCarames
Posted
@DragonFireShield
Glad I could help! Keep it up!