Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="card"> with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/
To center .card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body. instead of giving .card position: absolute and its properties.
Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@MouradBouzgmaPosted almost 2 years ago@Hassiai thanks for your help I appreciate it I will add this to my new projects
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord