Product preview card component

Community feedback

• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  Hello @saul!

  Great Job solving the challenge mate congrats 🎉

  Some suggestions for improvements.

  For the font-size it's is recommended to use rems and ems.

  font-size: 13px;

  i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  You should use ems, and rems for font-sizes would be better

  This article may help:

  (https://fedmentor.dev/posts/font-size-px/)

  ➖➖➖➖➖➖➖➖

  Use <main> to wrap the main content instead of <div>. * 📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  ➖➖➖➖➖➖➖

  Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.

  <h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>

  Other than that you're good, keep up the good work!

  Marked as helpful

  0

  ---

  

  Saúl Gutiérrez•210

  @saulgutierrezPosted 9 months ago

  Hello @hassanmoaa!

  As a student, I really apreciate your feedback. I will practice the advices you gave me. If you have any other suggestions or recommendations, feel free to write to me, I'm glad you took the time for feedback!

  1